What I am not sure of is if this will really get used with the procesing chain / config

not yet. the parameters from the ak arrays are not stored into the lgdo for now...

Also ak.Array(..., attrs=...) is wrong; these attrs cannot be retreived any more. There is no way to do that in one line of code without being ugly.

a = ak.Array(np.array([1,2,4]), attrs={"unit": "m"})
ak.parameters(a)  # {}


a = ak.Array(np.array([1,2,4]))
a = ak.with_parameter(a, "unit", "m")
ak.parameters(a)  # {'unit': 'm'}

I do not understand

>>> ak.Array([1,2,3],attrs={"units":"kev"}).attrs
{'units': 'kev'}

works nicely

I think this is now fixed, but we should think about having much testing of the units handling. Eg for every processor:

• Is the right unit returned?
• Are the units used correctly (and not eg. just discarded)?

This will take time

Codecov Report

❌ Patch coverage is 94.79167% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.04%. Comparing base (0f7fc07) to head (d43449a).
⚠️ Report is 5 commits behind head on main.

@@            Coverage Diff             @@
##             main     #121      +/-   ##
==========================================
+ Coverage   69.72%   70.04%   +0.31%     
==========================================
  Files          33       33              
  Lines        2583     2597      +14     
==========================================
+ Hits         1801     1819      +18     
+ Misses        782      778       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

I think this is good to go and can be merged now, any objection?

Ok let's wait until we properly test this

We should try to make some progress here...

Since we break the interface, we should also fix things like #136 before releasing a new version

i think this is now ok, but the testing maybe you be improved? @ManuelHu / @gipert

I think we need to do some more work to support units in reshaping?

Related: legend-exp/legend-pydataobj#207

can you also add some docs about the new conventions?

can you also add some docs about the new conventions?

the old docs are here: